-
-
Notifications
You must be signed in to change notification settings - Fork 377
Adding translator Dapeng Wang #2878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dapeng Wang has been translating to Chinese
WalkthroughThe changes update the documentation and translation files for pgRouting. A new section specifically acknowledging translators, with "Dapeng Wang" listed, has been added. "Dapeng Wang" is also included in the alphabetical list of contributors. The redundant "(Alphabetical order)" line was removed from the contributors section. Translation template and translation files were updated to reflect these changes, including a new POT-Creation-Date. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
👮 Files not reviewed due to content moderation or server errors (1)
🧰 Additional context used🧠 Learnings (2)locale/pot/pgrouting_doc_strings.pot (1)undefined <retrieved_learning> locale/en/LC_MESSAGES/pgrouting_doc_strings.po (3)undefined <retrieved_learning> <retrieved_learning> <retrieved_learning> ⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (4)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
doc/src/pgRouting-introduction.rst(2 hunks)locale/en/LC_MESSAGES/pgrouting_doc_strings.po(3 hunks)locale/pot/pgrouting_doc_strings.pot(3 hunks)
👮 Files not reviewed due to content moderation or server errors (2)
- locale/en/LC_MESSAGES/pgrouting_doc_strings.po
- locale/pot/pgrouting_doc_strings.pot
🔇 Additional comments (1)
doc/src/pgRouting-introduction.rst (1)
115-115: Confirm alphabetical insertion in Past & Present contributors
"Dapeng Wang," is correctly placed between "Daniel Kastl," and "Dave Potts," in the alphabetical list, with consistent comma usage.
| Translators (in alphabetical order) | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| Dapeng Wang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Refine translators section formatting
Ensure the caret underline exactly matches the heading text length for proper reStructuredText rendering. Optionally, convert the translator list to a bullet list (e.g., - Dapeng Wang) to align with the "Corporate Sponsors" section style and simplify future additions.
🤖 Prompt for AI Agents (early access)
In doc/src/pgRouting-introduction.rst around lines 78 to 81, the underline of the "Translators (in alphabetical order)" heading does not exactly match the heading text length, which can cause rendering issues in reStructuredText. Adjust the caret underline to be the same length as the heading text. Additionally, convert the translator name into a bullet list item by prefixing it with a dash and a space (e.g., "- Dapeng Wang") to match the style of the "Corporate Sponsors" section and make future additions easier.
Dapeng Wang has been translating to Chinese
Changes proposed in this pull request:
@pgRouting/admins
Summary by CodeRabbit