Skip to content

Limit ACL check of the large flat tree #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k5342 merged 1 commit into from
Jul 16, 2024
Merged

Limit ACL check of the large flat tree #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,17 +1114,18 @@ private boolean checkChildrenAcls(OzoneObj ozObject, RequestContext context)
if (ozoneFileStatus.isDirectory() && hasAccess) {
directories.add(ozoneFileStatus);
}
long keys_scanned = 0;
while (!directories.isEmpty() && hasAccess) {
if (directories.size() >
ozoneManager.getConfiguration()
.getInt(OZONE_OM_ACL_CHECK_MAX_CHILDREN, 300)) {
throw new OMException("Too much entries for ACL check", TIMEOUT);
}
ozoneFileStatus = directories.pop();
String keyPath = ozoneFileStatus.getTrimmedName();
Iterator<? extends OzoneFileStatus> children =
ozObject.getOzonePrefixPathViewer().getChildren(keyPath);
while (hasAccess && children.hasNext()) {
if (keys_scanned >
ozoneManager.getConfiguration()
.getInt(OZONE_OM_ACL_CHECK_MAX_CHILDREN, 1_000_000)) {
throw new OMException("Too much entries for ACL check", TIMEOUT);
}
ozoneFileStatus = children.next();
keyInfo = ozoneFileStatus.getKeyInfo();
hasAccess = OzoneAclUtil.checkAclRights(keyInfo.getAcls(), context);
Expand All @@ -1135,6 +1136,7 @@ private boolean checkChildrenAcls(OzoneObj ozObject, RequestContext context)
if (hasAccess && ozoneFileStatus.isDirectory()) {
directories.add(ozoneFileStatus);
}
keys_scanned += 1;
}
}
return hasAccess;
Expand Down