Skip to content

feat: allows merging pezzo options with openai options#270

Merged
arielweinberger merged 5 commits intopezzolabs:mainfrom
lh0x00:feature/MergePezzoOpenAIOptions
Nov 17, 2023
Merged

feat: allows merging pezzo options with openai options#270
arielweinberger merged 5 commits intopezzolabs:mainfrom
lh0x00:feature/MergePezzoOpenAIOptions

Conversation

@lh0x00
Copy link
Contributor

@lh0x00 lh0x00 commented Nov 14, 2023

Being able to only use one of the two is a limitation, and I encountered the fact that if I used pezzo's variables I couldn't add headers to the request, so I suggested updating it.

Please take a look and merge if it's ok.

@lh0x00
Copy link
Contributor Author

lh0x00 commented Nov 14, 2023

@arielweinberger thanks for review

@arielweinberger
Copy link
Member

I understand the need - thanks for the PR @lh0x00. I was thinking to move the OpenAI options to the 3rd argument rather than the 2nd, so no merging, just because some of the parameter names used in Pezzo such as properties, variables and cache could potentially create conflicts with future parameters introduced by OpenAI. Thoughts?

@lh0x00
Copy link
Contributor Author

lh0x00 commented Nov 14, 2023

@arielweinberger I agree with this, and I will update it.

@lh0x00
Copy link
Contributor Author

lh0x00 commented Nov 15, 2023

hi @arielweinberger do you need me to update anything else? because I'm waiting for its release to use directly instead of a fork of pezzo. If possible, please help me review it as soon as possible, thank you.

@arielweinberger
Copy link
Member

@lh0x00 Will merge ASAP. Can you fix formatting? npx nx format:write --all

@lh0x00
Copy link
Contributor Author

lh0x00 commented Nov 16, 2023

@arielweinberger I have updated it again, thanks for review.

@arielweinberger
Copy link
Member

arielweinberger commented Nov 16, 2023

Please make the 3rd argument optional (and handle the case in which it is undefined). CI fails.

@lh0x00
Copy link
Contributor Author

lh0x00 commented Nov 16, 2023

I updated it.

@arielweinberger
Copy link
Member

This should be alright @lh0x00 I'll run some tests and if all is good I'll push and release.

@arielweinberger arielweinberger merged commit 164aa4e into pezzolabs:main Nov 17, 2023
@arielweinberger
Copy link
Member

@lh0x00 should be live at @pezzo/client@0.4.18

@lh0x00
Copy link
Contributor Author

lh0x00 commented Nov 18, 2023

thank you so much, @arielweinberger

@lh0x00 lh0x00 deleted the feature/MergePezzoOpenAIOptions branch November 18, 2023 04:58
arielweinberger pushed a commit that referenced this pull request Mar 9, 2025
* feat: allows merging pezzo options with openai options

* chore: move `openaiOptions` to 3rd parameter instead of merge with `pezzoOptions`

* chore: delete `yarn.lock` file

* chore: format code

* chore: make 3rd parameter is optional
arielweinberger pushed a commit that referenced this pull request Mar 9, 2025
* feat: allows merging pezzo options with openai options

* chore: move `openaiOptions` to 3rd parameter instead of merge with `pezzoOptions`

* chore: delete `yarn.lock` file

* chore: format code

* chore: make 3rd parameter is optional
arielweinberger pushed a commit that referenced this pull request Mar 9, 2025
* feat: allows merging pezzo options with openai options

* chore: move `openaiOptions` to 3rd parameter instead of merge with `pezzoOptions`

* chore: delete `yarn.lock` file

* chore: format code

* chore: make 3rd parameter is optional
arielweinberger pushed a commit that referenced this pull request Mar 9, 2025
* feat: allows merging pezzo options with openai options

* chore: move `openaiOptions` to 3rd parameter instead of merge with `pezzoOptions`

* chore: delete `yarn.lock` file

* chore: format code

* chore: make 3rd parameter is optional
arielweinberger pushed a commit that referenced this pull request Mar 9, 2025
* feat: allows merging pezzo options with openai options

* chore: move `openaiOptions` to 3rd parameter instead of merge with `pezzoOptions`

* chore: delete `yarn.lock` file

* chore: format code

* chore: make 3rd parameter is optional
arielweinberger pushed a commit that referenced this pull request Mar 9, 2025
* feat: allows merging pezzo options with openai options

* chore: move `openaiOptions` to 3rd parameter instead of merge with `pezzoOptions`

* chore: delete `yarn.lock` file

* chore: format code

* chore: make 3rd parameter is optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants