feat: allows merging pezzo options with openai options#270
feat: allows merging pezzo options with openai options#270arielweinberger merged 5 commits intopezzolabs:mainfrom
Conversation
|
@arielweinberger thanks for review |
|
I understand the need - thanks for the PR @lh0x00. I was thinking to move the OpenAI options to the 3rd argument rather than the 2nd, so no merging, just because some of the parameter names used in Pezzo such as |
|
@arielweinberger I agree with this, and I will update it. |
|
hi @arielweinberger do you need me to update anything else? because I'm waiting for its release to use directly instead of a fork of pezzo. If possible, please help me review it as soon as possible, thank you. |
|
@lh0x00 Will merge ASAP. Can you fix formatting? |
|
@arielweinberger I have updated it again, thanks for review. |
|
Please make the 3rd argument optional (and handle the case in which it is undefined). CI fails. |
|
I updated it. |
|
This should be alright @lh0x00 I'll run some tests and if all is good I'll push and release. |
|
@lh0x00 should be live at |
|
thank you so much, @arielweinberger |
* feat: allows merging pezzo options with openai options * chore: move `openaiOptions` to 3rd parameter instead of merge with `pezzoOptions` * chore: delete `yarn.lock` file * chore: format code * chore: make 3rd parameter is optional
* feat: allows merging pezzo options with openai options * chore: move `openaiOptions` to 3rd parameter instead of merge with `pezzoOptions` * chore: delete `yarn.lock` file * chore: format code * chore: make 3rd parameter is optional
* feat: allows merging pezzo options with openai options * chore: move `openaiOptions` to 3rd parameter instead of merge with `pezzoOptions` * chore: delete `yarn.lock` file * chore: format code * chore: make 3rd parameter is optional
* feat: allows merging pezzo options with openai options * chore: move `openaiOptions` to 3rd parameter instead of merge with `pezzoOptions` * chore: delete `yarn.lock` file * chore: format code * chore: make 3rd parameter is optional
* feat: allows merging pezzo options with openai options * chore: move `openaiOptions` to 3rd parameter instead of merge with `pezzoOptions` * chore: delete `yarn.lock` file * chore: format code * chore: make 3rd parameter is optional
* feat: allows merging pezzo options with openai options * chore: move `openaiOptions` to 3rd parameter instead of merge with `pezzoOptions` * chore: delete `yarn.lock` file * chore: format code * chore: make 3rd parameter is optional
Being able to only use one of the two is a limitation, and I encountered the fact that if I used pezzo's
variablesI couldn't addheadersto the request, so I suggested updating it.Please take a look and merge if it's ok.