Refactor binary sensors

[Drealine]

Hi
It's me again. Did you think it can be more usual to have magnet open detection as binary_sensor and not as sensor in HA ?
Thank you

[petrleocompel]

Magnet "presence" is binary_sensor

[petrleocompel]

hikaxpro_hacs/custom_components/hikvision_axpro/sensor.py

Line 172 in 61aa83c

class HikWirelessExtMagnetDetector(CoordinatorEntity, HikDevice, BinarySensorEntity):

hikaxpro_hacs/custom_components/hikvision_axpro/sensor.py

Line 228 in 61aa83c

class HikMagneticContactDetector(CoordinatorEntity, HikDevice, BinarySensorEntity):

hikaxpro_hacs/custom_components/hikvision_axpro/sensor.py

Line 282 in 61aa83c

class HikMagnetShockDetector(CoordinatorEntity, HikDevice, BinarySensorEntity):

hikaxpro_hacs/custom_components/hikvision_axpro/sensor.py

Line 349 in 61aa83c

class HikMagnetOpenDetector(CoordinatorEntity, HikDevice, BinarySensorEntity):

hikaxpro_hacs/custom_components/hikvision_axpro/sensor.py

Line 416 in 61aa83c

class HikMagnetTiltDetector(CoordinatorEntity, HikDevice, BinarySensorEntity):

All of them are BinarySensorEntity

[Drealine]

It's strange. All sensors of MagnetShockDetector are sensor.**** and not binary_sensor.***. See bellow :

[petrleocompel]

I feel like you mixing up dev terminology and ui terminology

[Drealine]

Yes you've reason. So the FR is for UI.

[petrleocompel]

Okay UI see now what you mean. Refactor will be to change move those from sensor.py to binary_sensor.py and initialize them as binary sensors. Sadly not too easy you can expect such a thing in next release 2.2.0

[xoferz]

For what its worth, same goes for AXPro motion sensors. Most of the gui and other integrations do not seem to consider them binary sensors. I did the following in configuration.yaml as a workaround:

    pir_esik:
      friendly_name: "Esik liikumisandur (AXPro)"
      value_template: "{{ is_state('sensor.ax_pro_xxx_status_23', 'trigger')}}"
      device_class: motion
      unique_id: pir_ax_pro_xxx_status_23