Draft: Support ellipses #19
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 94120b0): https://js-draw--pr19-work-ellipse-support-cgk57k5h.web.app (expires Fri, 30 Jun 2023 00:33:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e560ee6f7bb6b79cb55b42fb4c05e9fd1b5c506e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for loading/saving ellipses.
To-do
Path.toString.test.ts: Add tests for saving ellipses.Path.fromString.test.ts: Add additional tests for loading ellipses.Path.ts: Fix and test broken logic for transforming elliptical path segments.EllipticalArc.test.ts: Add additional tests forfromStartEndand fix the"fromStartEnd should produce a circle if rx = ry"test.