-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix: iOS TextField gray overlay when running on macOS with Increase Contrast disabled #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@jackjackbits just a heads up: we’ve seen 5+ reports of this issue tied to how the app is bundled and delivered via the App Store, which ends up serving it as an iOS build. |
|
but why are we turning off autocorrection for people? that would be unexpected behavior. |
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Issue: When the iOS app is downloaded from the Mac App Store and run on Apple Silicon Macs, a gray overlay appears over TextField components when Increase Contrast accessibility setting is disabled. Reproduction: 1. Download bitchat iOS app from Mac App Store 2. Run on Apple Silicon Mac 3. Disable 'Increase Contrast' in System Settings > Accessibility > Display 4. Focus on text input field - gray overlay appears Fix: Use ProcessInfo.processInfo.isiOSAppOnMac runtime detection to disable autocorrection only when iOS app runs on macOS. This targets the exact environment where the issue occurs while preserving normal autocorrection behavior for iPhone/iPad users. Addresses code review feedback about incorrect conditional compilation.
|
@codex review round 3 |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
Fix: iOS TextField gray overlay when running on macOS with Increase Contrast disabled
This PR fixes issue #515, where text becomes invisible in the message input field when the iOS app is running on macOS with the "Increase Contrast" accessibility setting disabled. The fix adds iOS-specific modifiers to prevent the gray overlay from appearing on text fields.
Changes
.autocorrectionDisabled(true)modifier to prevent predictive text overlay.focusEffectDisabled()modifier to disable the system focus effect#if os(iOS)to ensure they only apply to the iOS buildTesting