Implement browser restart functionality on disconnection and enhance retry logic in discovery #2054
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces robust browser recovery and retry logic to improve reliability when the browser disconnects or crashes during asset discovery and snapshot operations. The main changes add automatic browser restart handling to the
Browserclass, integrate error-aware retries in the snapshot discovery queue, and enhance thewithRetriesutility to pass error details to retry callbacks. Comprehensive tests have been added to ensure correct behavior across various failure scenarios.Browser recovery and retry logic:
restartmethod to theBrowserclass that force-closes the browser, resets internal state, clears callbacks and sessions, and launches a new browser instance. (packages/core/src/browser.js)page()method inBrowserto automatically restart the browser if it is disconnected before creating a new page. (packages/core/src/browser.js)packages/core/src/discovery.js)withRetriesutility to pass the error object to theonRetrycallback, allowing more context-aware retry logic. (packages/core/src/utils.js)Testing and validation:
withRetriesutility, covering error passing, async callbacks, and error handling. (packages/core/test/discovery.test.js,packages/core/test/utils.test.js) [1] [2]