PMM-14694 Reduce saas package dependency, drop Portal API #4900
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v3 #4900 +/- ##
==========================================
+ Coverage 45.80% 46.29% +0.48%
==========================================
Files 367 377 +10
Lines 38531 39011 +480
==========================================
+ Hits 17648 18059 +411
+ Misses 19182 19152 -30
- Partials 1701 1800 +99
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
idoqo
requested review from
JiriCtvrtka,
ademidoff and
maxkondr
and removed request for
a team
There was a problem hiding this comment.
as I remember signatures were used in order to make sure that received data (advisor, alert template, etc) are really originated by Percona (signed by Percona's private key). in case the templates are moved to pmm repo itself - is it still required to check the signature?
There was a problem hiding this comment.
You are raising a good question! Let's prepare for a discussion on the next BE call.
There was a problem hiding this comment.
FYI: we will be asked to source the advisors and alert templates from a GitHub repo. This is why I'm a bit reluctant to drop them now. It's never late to do that.
* drop portal communication * drop platform connections that are unrelated to telemetry * mark platform fields as deprecated * Bump anchore/sbom-action from 0.21.1 to 0.22.0 (#4952) Bumps [anchore/sbom-action](https://github.com/anchore/sbom-action) from 0.21.1 to 0.22.0. - [Release notes](https://github.com/anchore/sbom-action/releases) - [Changelog](https://github.com/anchore/sbom-action/blob/main/RELEASE.md) - [Commits](anchore/sbom-action@0b82b0b...62ad528) --- updated-dependencies: - dependency-name: anchore/sbom-action dependency-version: 0.22.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ademidoff
changed the title
ademidoff
changed the title
4 participants
PMM-14694
PMM-14012
Percona-Lab/pmm-submodules#4182