K8SPXC-1647: Use extended exit codes for garbd #2076
Draft
+91
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
size/M
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| --parallel="$(grep -c processor /proc/cpuinfo)" \ | ||
| $XBCLOUD_ARGS \ | ||
| "$BACKUP_PATH" 2>&1 \ | ||
| | (grep -v "error: http request failed: Couldn't resolve host name" || exit 1) & |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| | (grep -v "error: http request failed: Couldn't resolve host name" || exit 1) & | |
| | (grep -v "error: http request failed: Couldn't resolve host name" || exit 1) & |
egegunes
force-pushed
the
K8SPXC-1647
branch
from
e995968 to
09e03a9
Compare
hors
reviewed
Nov 29, 2025
| --extended-exit-codes \ | ||
| --wait-for-recv-script-exit \ | ||
| --recv-script="/opt/percona/backup/run_backup.sh" | ||
| GARBD_EXIT_CODE=$? |
Collaborator
There was a problem hiding this comment.
@egegunes please make sure that it will work for PXC 5.7 as well
I did not find 5.7 in fixed versions :(
https://perconadev.atlassian.net/browse/PXC-4645
Comment on lines
+134
to
+141
| --address "gcomm://$NODE_NAME.$PXC_SERVICE?gmcast.listen_addr=tcp://0.0.0.0:4567" \ | ||
| --donor "$NODE_NAME" \ | ||
| --group "$PXC_SERVICE" \ | ||
| --options "$GARBD_OPTS" \ | ||
| --sst "xtrabackup-v2:$LOCAL_IP:4444/xtrabackup_sst//1" \ | ||
| --extended-exit-codes \ | ||
| --wait-for-recv-script-exit \ | ||
| --recv-script="/opt/percona/backup/run_backup.sh" |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| --address "gcomm://$NODE_NAME.$PXC_SERVICE?gmcast.listen_addr=tcp://0.0.0.0:4567" \ | |
| --donor "$NODE_NAME" \ | |
| --group "$PXC_SERVICE" \ | |
| --options "$GARBD_OPTS" \ | |
| --sst "xtrabackup-v2:$LOCAL_IP:4444/xtrabackup_sst//1" \ | |
| --extended-exit-codes \ | |
| --wait-for-recv-script-exit \ | |
| --recv-script="/opt/percona/backup/run_backup.sh" | |
| --address "gcomm://$NODE_NAME.$PXC_SERVICE?gmcast.listen_addr=tcp://0.0.0.0:4567" \ | |
| --donor "$NODE_NAME" \ | |
| --group "$PXC_SERVICE" \ | |
| --options "$GARBD_OPTS" \ | |
| --sst "xtrabackup-v2:$LOCAL_IP:4444/xtrabackup_sst//1" \ | |
| --extended-exit-codes \ | |
| --wait-for-recv-script-exit \ | |
| --recv-script="/opt/percona/backup/run_backup.sh" |
Comment on lines
+145
to
+164
| 0) | ||
| log 'INFO' 'Backup was finished successfully' | ||
| exit 0 | ||
| ;; | ||
| 100) | ||
| log 'ERROR' 'Backup was unsuccessful: Generic failure' | ||
| exit 1 | ||
| ;; | ||
| 101) | ||
| log 'ERROR' 'Backup was unsuccessful: Donor disappeared' | ||
| exit 1 | ||
| ;; | ||
| 102) | ||
| log 'ERROR' 'Backup was unsuccessful: SST request failure' | ||
| exit 1 | ||
| ;; | ||
| *) | ||
| log 'ERROR' "Backup was unsuccessful: garbd exited with ${GARBD_EXIT_CODE}" | ||
| exit 1 | ||
| ;; |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| 0) | |
| log 'INFO' 'Backup was finished successfully' | |
| exit 0 | |
| ;; | |
| 100) | |
| log 'ERROR' 'Backup was unsuccessful: Generic failure' | |
| exit 1 | |
| ;; | |
| 101) | |
| log 'ERROR' 'Backup was unsuccessful: Donor disappeared' | |
| exit 1 | |
| ;; | |
| 102) | |
| log 'ERROR' 'Backup was unsuccessful: SST request failure' | |
| exit 1 | |
| ;; | |
| *) | |
| log 'ERROR' "Backup was unsuccessful: garbd exited with ${GARBD_EXIT_CODE}" | |
| exit 1 | |
| ;; | |
| 0) | |
| log 'INFO' 'Backup was finished successfully' | |
| exit 0 | |
| ;; | |
| 100) | |
| log 'ERROR' 'Backup was unsuccessful: Generic failure' | |
| exit 1 | |
| ;; | |
| 101) | |
| log 'ERROR' 'Backup was unsuccessful: Donor disappeared' | |
| exit 1 | |
| ;; | |
| 102) | |
| log 'ERROR' 'Backup was unsuccessful: SST request failure' | |
| exit 1 | |
| ;; | |
| *) | |
| log 'ERROR' "Backup was unsuccessful: garbd exited with ${GARBD_EXIT_CODE}" | |
| exit 1 | |
| ;; |
Collaborator
commit: ee1be0b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
TODO:
garbdsays/* Reserved 99 exit codes. recv-script should use exit codes 0 or > GARBD_EXIT_CODE_LAST*/. We need to use exit codes >200 if we have any failure in recv script that we want to distinguish.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability