Skip to content

Reject requests if bot can not access repository #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Reject requests if bot can not access repository #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pep8speaks/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ def __init__(self, request, event):
self.request = request.json
self.event = event

self.OK = self._is_request_valid(request, event)
self.OK = self._is_request_valid(self.request, event)

# Dictionary with filename matched with corresponding list of results
self.results = {}
Expand All @@ -23,6 +23,7 @@ def __init__(self, request, event):
# Generic object for the pull request of payload
self.pull_request = self._get_pull_request(request, event)


self._set_properties(request, event)

def _get_pull_request(self, request, event):
Expand All @@ -42,12 +43,17 @@ def _get_pull_request(self, request, event):
return pull_request

def _is_request_valid(self, request, event):
# The bot should be able to access the repository
r = utils.query_request(request['repository']['url'])
if not r.ok:
return False

# A valid pull request payload can only be created or updated with commits
if event == 'pull_request':
if request.json['action'] in ['synchronize', 'opened', 'reopened']:
if request['action'] in ['synchronize', 'opened', 'reopened']:
return True
elif event == 'issue_comment':
if request.json['action'] in ('created', 'edited') and 'pull_request' in request.json['issue']:
if request['action'] in ('created', 'edited') and 'pull_request' in request.json['issue']:
return True

return False
Expand Down