Skip to content

add both formats to copyable address component#642

Closed
gianfra-t wants to merge 2 commits intomainfrom
unified-address-changes
Closed

add both formats to copyable address component#642
gianfra-t wants to merge 2 commits intomainfrom
unified-address-changes

Conversation

@gianfra-t
Copy link
Copy Markdown
Contributor

@gianfra-t gianfra-t commented Mar 4, 2025

No description provided.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 4, 2025

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit 3b2d5be
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/67cb49ac6042370008698b1d
😎 Deploy Preview https://deploy-preview-642--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gianfra-t gianfra-t changed the title add both format to copyable address component add both formats to copyable address component Mar 5, 2025
@ebma ebma requested a review from a team March 12, 2025 11:22
Copy link
Copy Markdown
Member

@Sharqiewicz Sharqiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By my mind to not complicate the situation in the app, we should go for new addresses only and show an announcement at the top of the website that there is a new address format and place a link to an article explaining everything. wdyt @gianfra-t @ebma

@Sharqiewicz
Copy link
Copy Markdown
Member

@pendulum-chain/devs

@gianfra-t
Copy link
Copy Markdown
Contributor Author

Fine by me! Then the change should happen automatically in this repo.

@ebma
Copy link
Copy Markdown
Member

ebma commented Mar 18, 2025

We should go for new addresses only and show an announcement at the top of the website that there is a new address format and place a link to an article explaining everything.

I agree. It's a nice idea with opening the extra dialog with two formats on click, however it's also not ideal in the sense that if I as a user am confused about seeing a different address, I surely wouldn't expect to see a dialog open when I click on a copyable address. So this does not really address the confusion users are seeing as it's still kind of hidden.

Let's just add the banner and a link to the documentation shared with us.

@ebma ebma closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants