Skip to content

update version of substrate dependencies to polkadot v0940#9

Merged
b-yap merged 4 commits intopolkadot-v0.9.40from
219-update-runtimes-to-polkadot-v0940
May 23, 2023
Merged

update version of substrate dependencies to polkadot v0940#9
b-yap merged 4 commits intopolkadot-v0.9.40from
219-update-runtimes-to-polkadot-v0940

Conversation

@b-yap
Copy link
Copy Markdown

@b-yap b-yap commented May 18, 2023

partially closes pendulum issue 219

General overview of the changes:

  1. rename grandpa traits
  2. rename random-collective-flip crates
  3. conversion of <T as frame_system::Config>::Origin::from(RawOrigin::Root) to a shorter: RawOrigin::Root.into() in benchmarking.rs
  4. generate new weights for all extrinsics
  5. update implementation of pallet_grandpa in runtime
  6. added the toolchain so it's consistent with spacewalk

@b-yap b-yap requested a review from a team May 18, 2023 09:29
Copy link
Copy Markdown

@TorstenStueber TorstenStueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for upgrading this whole repository. It is unfortunate that together with the pallet we have a whole runtime and node here, although we only need the pallet. This makes upgrading to a new Polkadot version much harder.

We should consider to change this in the future.

@b-yap b-yap requested review from TorstenStueber and ebma May 23, 2023 05:59
Copy link
Copy Markdown
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really great that you got the benchmarking working again but we have to be careful with the values as I think we changed few of them manually (as the benchmarks were broken at the time). Let's maybe remove the weight generation from this PR again as you suggested @b-yap.

@b-yap b-yap requested a review from ebma May 23, 2023 08:33
Copy link
Copy Markdown
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me

@b-yap b-yap merged commit 1b20de9 into polkadot-v0.9.40 May 23, 2023
@b-yap b-yap deleted the 219-update-runtimes-to-polkadot-v0940 branch May 23, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants