Skip to content

fix HTU comparison to skip fragments #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ylebre merged 1 commit into from
May 28, 2025
Merged

fix HTU comparison to skip fragments #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/Utils/DPop.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,14 +321,16 @@ public function validateDpop($dpop, $request) {
// 7. the "htu" claims matches the HTTP URI value for the HTTP request
// in which the JWT was received, ignoring any query and fragment
// parts,
$requestedPath = (string)$request->getUri();
$requestedPath = preg_replace("/[?#].*$/", "", $requestedPath);

//error_log("REQUESTED HTU $htu");
//error_log("REQUESTED PATH $requestedPath");
if ($htu != $requestedPath) {
throw new InvalidTokenException("htu does not match requested path");
}
$requestedPath = (string)$request->getUri();
$requestedPath = preg_replace("/[?#].*$/", "", $requestedPath);
$htuClean = preg_replace("/[?#].*$/", "", $htu);
// error_log("REQUESTED HTU $htu");
// error_log("REQUESTED HTU cleaned $htuClean");
// error_log("REQUESTED PATH $requestedPath");
if ($htuClean != $requestedPath) {
throw new InvalidTokenException("htu does not match requested path");
}

// 8. the token was issued within an acceptable timeframe (see Section 9.1), and

Expand Down