⚡️ Optimise mul_div Method
#153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We simplify the
twoscalculation inmul_divin a similar way as proposed here. This will save one operation.Explanation:
-xin two's complement (wherexisuint256) is defined as~x + 1which ismax_value(uint256) - x + 1. Thus,-x -> 0 + max_value(uint256) - x + 1 -> unsafe_sub(0, x)as long asx>=1holds.Furthermore, we bump
eslint-config-prettier,ethers, andprettierto the corresponding latest versions. Eventually, the submoduleopenzeppelin-contractsis bumped to the latest available commit.🐶 Cute Animal Picture