Merged
Conversation
This was referenced Jul 30, 2025
johslarsen
approved these changes
Jul 30, 2025
Keep ANSI escape sequences used for coloring and font formatting in the message body, while removing potentially dangerous sequences that may be used for escape sequence attacks. Fixes issue pazz#1679.
lfos
force-pushed
the
allow-sgr-sequences
branch
from
550fe87 to
e9ab03c
Compare
pazz
approved these changes
Jul 30, 2025
Owner
pazz
left a comment
pazz
left a comment
There was a problem hiding this comment.
looks like a good and safe compromise to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep ANSI escape sequences used for coloring and font formatting in the message body, while removing potentially dangerous sequences that may be used for escape sequence attacks.
Fixes issue #1679.