Conversation
pazz
approved these changes
Aug 6, 2024
Owner
pazz
left a comment
pazz
left a comment
There was a problem hiding this comment.
I think it is a great idea to avoid duplication of the dependencies.
Otherwise inevitably these will diverge and possibly create issues.
Perhaps you could add one larger comment before the affected lines explaining that the following replaces explicit dependencies and instead extracts them from the setuptools config?
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pazz this is the result of my comment #1666 (comment) . This makes the nix code a little more complicated but removes the need to specify our dependencies twice. As I know nix quite well I like it but I am unsure if it raises the bar for others to look at the nix code (do we care about that?). What do you think?