feat(tokens): prefix with t_ #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Looks great! Just need to update now that I merged #763
adamviktora
force-pushed
the
tokens-t-prefix
branch
from
3da9dd1 to
acc5f13
Compare
| @@ -0,0 +1,856 @@ | |||
| // all React tokens in V6, whose value is a Patternfly token variable (has prefix --pf-t) | |||
| // their naming was updated to be prefixed with 't_' | |||
| export const tTokens = [ | |||
Collaborator
There was a problem hiding this comment.
Super small nit, but wondering if this would make more sense named "reactTokens" or "tokensPrefixedWithT". Not a blocker and good to merge this as-is, justlet me know what you think.
Contributor
Author
There was a problem hiding this comment.
yeah, tokensPrefixedWithT is good. I wouldn't use reactTokens, because also the pf-v6-whatever are react tokens
thatblindgeye
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #771