Skip to content

fix(ClipboardCopy): remove popoverposition #8226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 3 commits into from
Oct 13, 2022
Merged

fix(ClipboardCopy): remove popoverposition #8226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b84eab
fix(ClipboardCopy): remove popoverposition
gitdallas Oct 13, 2022
af50847
edit doc comment
gitdallas Oct 13, 2022
947c2fa
remove popover type from clipboardcopybutton
gitdallas Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as React from 'react';
import styles from '@patternfly/react-styles/css/components/ClipboardCopy/clipboard-copy';
import { css } from '@patternfly/react-styles';
import { PickOptional } from '../../helpers/typeUtils';
import { PopoverPosition } from '../Popover';
import { TooltipPosition } from '../Tooltip';
import { TextInput } from '../TextInput';
import { GenerateId } from '../../helpers/GenerateId/GenerateId';
Expand Down Expand Up @@ -53,9 +52,8 @@ export interface ClipboardCopyProps extends Omit<React.HTMLProps<HTMLDivElement>
isBlock?: boolean;
/** Adds Clipboard Copy variant styles. */
variant?: typeof ClipboardCopyVariant | 'inline' | 'expansion' | 'inline-compact';
/** Copy button popover position. */
/** Copy button tooltip position. */
position?:
| PopoverPosition
| TooltipPosition
| 'auto'
| 'top'
Expand Down Expand Up @@ -109,7 +107,7 @@ export class ClipboardCopy extends React.Component<ClipboardCopyProps, Clipboard
isExpanded: false,
isCode: false,
variant: 'inline',
position: PopoverPosition.top,
position: TooltipPosition.top,
maxWidth: '150px',
exitDelay: 1600,
entryDelay: 300,
Expand Down
2 changes: 0 additions & 2 deletions packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as React from 'react';
import CopyIcon from '@patternfly/react-icons/dist/esm/icons/copy-icon';
import { Button } from '../Button';
import { Tooltip, TooltipPosition } from '../Tooltip';
import { PopoverPosition } from '../Popover';

export interface ClipboardCopyButtonProps
extends Omit<React.DetailedHTMLProps<React.ButtonHTMLAttributes<HTMLButtonElement>, HTMLButtonElement>, 'ref'> {
Expand All @@ -25,7 +24,6 @@ export interface ClipboardCopyButtonProps
/** Position of the copy button tooltip */
position?:
| TooltipPosition
| PopoverPosition
| 'auto'
| 'top'
| 'bottom'
Expand Down