Skip to content

chore(SimpleList):convert to typescript #8176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 3 commits into from
Oct 18, 2022
Merged

chore(SimpleList):convert to typescript #8176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80c8494
chore(SimpleList):convert to typescript
Oct 5, 2022
3fca0f4
updated types to match onSelect handler
Oct 6, 2022
7c01b03
updated types to match onSelect handler and various name changes
Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 4 additions & 108 deletions packages/react-core/src/components/SimpleList/examples/SimpleList.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,120 +9,16 @@ propComponents: ['SimpleList', 'SimpleListGroup', 'SimpleListItem']

### Simple list

```js
import React from 'react';
import { SimpleList, SimpleListItem } from '@patternfly/react-core';

class SimpleListDemo extends React.Component {
onSelect(selectedItem, selectedItemProps) {
console.log('new selection SimpleListDemo', selectedItem, selectedItemProps);
}

render() {
const items = [
<SimpleListItem key="item1" isActive>
List item 1
</SimpleListItem>,
<SimpleListItem key="item2" component="a" href="#">
List item 2
</SimpleListItem>,
<SimpleListItem key="item3">List item 3</SimpleListItem>
];

return (
<SimpleList onSelect={this.onSelect} aria-label="Simple List Example">
{items}
</SimpleList>
);
}
}
```ts file="SimpleListBasic.tsx"
```

### Grouped list

```js
import React from 'react';
import { SimpleList, SimpleListItem, SimpleListGroup } from '@patternfly/react-core';

class SimpleListGroupDemo extends React.Component {
onSelect(selectedItem, selectedItemProps) {
console.log('new selection SimpleListGroupDemo', selectedItem, selectedItemProps);
}

render() {
const group1Items = [
<SimpleListItem key="item1" isActive>
List item 1
</SimpleListItem>,
<SimpleListItem key="item2" id="test 2">
List item 2
</SimpleListItem>,
<SimpleListItem key="item3">List item 3</SimpleListItem>,
<SimpleListItem key="item4">List item 4</SimpleListItem>
];

const group2Items = [
<SimpleListItem key="item5">List item 1</SimpleListItem>,
<SimpleListItem key="item6" component="a" href="#">
List item 2
</SimpleListItem>,
<SimpleListItem key="item7" component="a" href="#">
List item 3
</SimpleListItem>,
<SimpleListItem key="item8">List item 4</SimpleListItem>
];

return (
<SimpleList onSelect={this.onSelect} aria-label="Grouped List Example">
<SimpleListGroup title="Group 1" id="group-1">
{group1Items}
</SimpleListGroup>
<SimpleListGroup title="Group 2" id="group-2">
{group2Items}
</SimpleListGroup>
</SimpleList>
);
}
}
```ts file="SimpleListGrouped.tsx"
```

### Uncontrolled simple list

```js
import React from 'react';
import { SimpleList, SimpleListItem } from '@patternfly/react-core';

class SimpleListUncontrolledDemo extends React.Component {
constructor(props) {
super(props);
this.state = {
activeItem: 0
};
this.onSelect = (selectedItem, selectedItemProps) => {
console.log('new selection SimpleListUncontrolledDemo', selectedItem, selectedItemProps);
this.setState({ activeItem: selectedItemProps.itemId });
};
}

render() {
const { activeItem } = this.state;
const items = [
<SimpleListItem key="item1" itemId={0} isActive={activeItem === 0}>
List item 1
</SimpleListItem>,
<SimpleListItem key="item2" itemId={1} isActive={activeItem === 1}>
List item 2
</SimpleListItem>,
<SimpleListItem key="item3" itemId={2} isActive={activeItem === 2}>
List item 3
</SimpleListItem>
];

return (
<SimpleList onSelect={this.onSelect} isControlled={false} aria-label="Uncontrolled Simple List Example">
{items}
</SimpleList>
);
}
}
```ts file="SimpleListUncontrolled.tsx"
```

16 changes: 16 additions & 0 deletions packages/react-core/src/components/SimpleList/examples/SimpleListBasic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import React from 'react';
import { SimpleList, SimpleListItem } from '@patternfly/react-core';

export const SimpleListBasic: React.FunctionComponent = () => {
const items = [
<SimpleListItem key="item1" isActive>
List item 1
</SimpleListItem>,
<SimpleListItem key="item2" component="a" href="#">
List item 2
</SimpleListItem>,
<SimpleListItem key="item3">List item 3</SimpleListItem>
];

return <SimpleList aria-label="Simple List Example">{items}</SimpleList>;
};
35 changes: 35 additions & 0 deletions packages/react-core/src/components/SimpleList/examples/SimpleListGrouped.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import React from 'react';
import { SimpleList, SimpleListItem, SimpleListGroup } from '@patternfly/react-core';

export const SimpleListGrouped: React.FunctionComponent = () => {
const group1Items = [
<SimpleListItem key="item1" isActive>
List item 1
</SimpleListItem>,
<SimpleListItem key="item2">List item 2</SimpleListItem>,
<SimpleListItem key="item3">List item 3</SimpleListItem>,
<SimpleListItem key="item4">List item 4</SimpleListItem>
];

const group2Items = [
<SimpleListItem key="item5">List item 1</SimpleListItem>,
<SimpleListItem key="item6" component="a" href="#">
List item 2
</SimpleListItem>,
<SimpleListItem key="item7" component="a" href="#">
List item 3
</SimpleListItem>,
<SimpleListItem key="item8">List item 4</SimpleListItem>
];

return (
<SimpleList aria-label="Grouped simple list example">
<SimpleListGroup title="Group 1" id="group-1">
{group1Items}
</SimpleListGroup>
<SimpleListGroup title="Group 2" id="group-2">
{group2Items}
</SimpleListGroup>
</SimpleList>
);
};
31 changes: 31 additions & 0 deletions packages/react-core/src/components/SimpleList/examples/SimpleListUncontrolled.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import React from 'react';
import { SimpleList, SimpleListItem, SimpleListItemProps } from '@patternfly/react-core';

export const SimpleListUncontrolled: React.FunctionComponent = () => {
const [activeItem, setActiveItem] = React.useState(0);

const onSelect = (
selectedItem: React.RefObject<HTMLButtonElement> | React.RefObject<HTMLAnchorElement>,
selectedItemProps: SimpleListItemProps
) => {
setActiveItem(selectedItemProps.itemId as number);
};

const items = [
<SimpleListItem key="item1" itemId={0} isActive={activeItem === 0}>
List item 1
</SimpleListItem>,
<SimpleListItem key="item2" itemId={1} isActive={activeItem === 1}>
List item 2
</SimpleListItem>,
<SimpleListItem key="item3" itemId={2} isActive={activeItem === 2}>
List item 3
</SimpleListItem>
];

return (
<SimpleList onSelect={onSelect} isControlled={false} aria-label="Uncontrolled Simple List Example">
{items}
</SimpleList>
);
};