Skip to content

fix(GenerateId): revert default behavior change #10232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlabaj merged 1 commit into from
Apr 1, 2024
Merged

fix(GenerateId): revert default behavior change #10232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-core/src/helpers/GenerateId/GenerateId.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ export interface GenerateIdProps {
prefix?: string;
/** Component to be rendered with the generated id */
children(id: string): React.ReactNode;
/** Flag to add randomness to the generated id, defaults to true */
/** Flag to add randomness to the generated id, should be used whenever possible */
isRandom?: boolean;
}

class GenerateId extends React.Component<GenerateIdProps, {}> {
static displayName = 'GenerateId';
static defaultProps = {
prefix: 'pf-random-id-',
isRandom: true
isRandom: false
};
uniqueElement = this.props.isRandom ? getRandomId() : currentId++;
id = `${this.props.prefix}${this.uniqueElement}`;
Expand Down