Skip to content

feat(TreeView): removed selectable modifier for penta #10101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 1 commit into from
Feb 28, 2024
Merged

feat(TreeView): removed selectable modifier for penta #10101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react-core/src/components/TreeView/TreeViewListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,6 @@ const TreeViewListItemBase: React.FunctionComponent<TreeViewListItemProps> = ({
<Component
className={css(
styles.treeViewNode,
children && (isSelectable || hasCheckbox) && 'pf-m-selectable',
(!children || isSelectable) &&
activeItems &&
activeItems.length > 0 &&
Expand Down
32 changes: 0 additions & 32 deletions packages/react-core/src/components/TreeView/__tests__/TreeViewListItem.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,38 +371,6 @@ test(`Does not render ${styles.treeViewNode} element with additional classes by
expect(treeViewNode).toHaveClass(styles.treeViewNode, { exact: true });
});

test(`Renders ${styles.treeViewNode} element with pf-m-selectable class when hasCheckbox and children are passed`, () => {
render(
<TreeViewListItem hasCheckbox {...requiredProps}>
Content
</TreeViewListItem>
);

const treeViewNode = screen.getByRole('treeitem').querySelector(`.${styles.treeViewNode}`);

expect(treeViewNode).toHaveClass('pf-m-selectable');
});

test(`Renders ${styles.treeViewNode} element with pf-m-selectable class when isSelectable and children are passed`, () => {
render(
<TreeViewListItem isSelectable {...requiredProps}>
Content
</TreeViewListItem>
);

const treeViewNode = screen.getByRole('treeitem').querySelector(`.${styles.treeViewNode}`);

expect(treeViewNode).toHaveClass('pf-m-selectable');
});

test(`Does not render ${styles.treeViewNode} element with pf-m-selectable if children are not passed`, () => {
render(<TreeViewListItem hasCheckbox isSelectable {...requiredProps} />);

const treeViewNode = screen.getByRole('treeitem').querySelector(`.${styles.treeViewNode}`);

expect(treeViewNode).not.toHaveClass('pf-m-selectable');
});

test(`Renders ${styles.treeViewNode} element with ${styles.modifiers.current} class when isSelectable and activeItems are passed`, () => {
render(
<TreeViewListItem compareItems={() => true} isSelectable activeItems={[{ name: 'Active item' }]} {...requiredProps}>
Expand Down