Skip to content

fix(Menu toggle): Passed aria label prop value to typeahead variant #10084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfrances17 merged 2 commits into from
Feb 19, 2024
Merged

fix(Menu toggle): Passed aria label prop value to typeahead variant #10084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18b270b
fix(Menu toggle): Passed aria label prop value to typeahead variant
tlabaj Feb 13, 2024
24f5690
Fix failing build. Add back default so it does not break consumers
tlabaj Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/MenuToggle/MenuToggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class MenuToggleBase extends React.Component<MenuToggleProps> {
className={css(styles.menuToggleButton)}
aria-expanded={isExpanded}
onClick={onClick}
aria-label="Menu toggle"
aria-label={ariaLabel || 'Menu toggle'}
>
{toggleControls}
</button>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/MenuToggle/examples/MenuToggleTypeahead.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const MenuToggleTypeahead: React.FunctionComponent = () => {
};

return (
<MenuToggle variant="typeahead" isFullWidth>
<MenuToggle variant="typeahead" isFullWidth aria-label="Typeahead menu toggle">
<TextInputGroup isPlain>
<TextInputGroupMain
value={inputValue}
Expand Down
9 changes: 8 additions & 1 deletion packages/react-core/src/components/Select/examples/SelectMultiTypeahead.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,14 @@ export const SelectMultiTypeahead: React.FunctionComponent = () => {
};

const toggle = (toggleRef: React.Ref<MenuToggleElement>) => (
<MenuToggle variant="typeahead" onClick={onToggleClick} innerRef={toggleRef} isExpanded={isOpen} isFullWidth>
<MenuToggle
variant="typeahead"
aria-label="Multi typeahead menu toggle"
onClick={onToggleClick}
innerRef={toggleRef}
isExpanded={isOpen}
isFullWidth
>
<TextInputGroup isPlain>
<TextInputGroupMain
value={inputValue}
Expand Down
9 changes: 8 additions & 1 deletion packages/react-core/src/components/Select/examples/SelectMultiTypeaheadCheckbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,14 @@ export const SelectMultiTypeaheadCheckbox: React.FunctionComponent = () => {
}, [selected]);

const toggle = (toggleRef: React.Ref<MenuToggleElement>) => (
<MenuToggle variant="typeahead" onClick={onToggleClick} innerRef={toggleRef} isExpanded={isOpen} isFullWidth>
<MenuToggle
variant="typeahead"
aria-label="Multi typeahead checkbox menu toggle"
onClick={onToggleClick}
innerRef={toggleRef}
isExpanded={isOpen}
isFullWidth
>
<TextInputGroup isPlain>
<TextInputGroupMain
value={inputValue}
Expand Down
9 changes: 8 additions & 1 deletion packages/react-core/src/components/Select/examples/SelectMultiTypeaheadCreatable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,14 @@ export const SelectMultiTypeaheadCreatable: React.FunctionComponent = () => {
};

const toggle = (toggleRef: React.Ref<MenuToggleElement>) => (
<MenuToggle variant="typeahead" onClick={onToggleClick} innerRef={toggleRef} isExpanded={isOpen} isFullWidth>
<MenuToggle
variant="typeahead"
aria-label="Multi typeahead creatable menu toggle"
onClick={onToggleClick}
innerRef={toggleRef}
isExpanded={isOpen}
isFullWidth
>
<TextInputGroup isPlain>
<TextInputGroupMain
value={inputValue}
Expand Down
9 changes: 8 additions & 1 deletion packages/react-core/src/components/Select/examples/SelectTypeahead.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,14 @@ export const SelectBasic: React.FunctionComponent = () => {
};

const toggle = (toggleRef: React.Ref<MenuToggleElement>) => (
<MenuToggle ref={toggleRef} variant="typeahead" onClick={onToggleClick} isExpanded={isOpen} isFullWidth>
<MenuToggle
ref={toggleRef}
variant="typeahead"
aria-label="Typeahead menu toggle"
onClick={onToggleClick}
isExpanded={isOpen}
isFullWidth
>
<TextInputGroup isPlain>
<TextInputGroupMain
value={inputValue}
Expand Down
9 changes: 8 additions & 1 deletion packages/react-core/src/components/Select/examples/SelectTypeaheadCreatable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,14 @@ export const SelectTypeaheadCreatable: React.FunctionComponent = () => {
};

const toggle = (toggleRef: React.Ref<MenuToggleElement>) => (
<MenuToggle ref={toggleRef} variant="typeahead" onClick={onToggleClick} isExpanded={isOpen} isFullWidth>
<MenuToggle
ref={toggleRef}
variant="typeahead"
aria-label="Typeahead creatable menu toggle"
onClick={onToggleClick}
isExpanded={isOpen}
isFullWidth
>
<TextInputGroup isPlain>
<TextInputGroupMain
value={inputValue}
Expand Down