feat(SimpleFileUpload): consumed Penta updates #10026
Conversation
| </InputGroupItem> | ||
| <InputGroupItem> | ||
| <Button | ||
| id={`${id}-browse-button`} |
There was a problem hiding this comment.
We could keep this in, but if we're going to expose an ID on the browse button then we should consider allowing an ID to be passed to all other input elements within the component. For now I included this in the codemod issue patternfly/pf-codemods#551
thatblindgeye
requested review from
a team,
andrew-ronaldson,
lboehling,
mattnolting,
nicolethoen and
wise-king-sullyman
and removed request for
a team
|
Preview: https://patternfly-react-pr-10026.surge.sh A11y report: https://patternfly-react-pr-10026-a11y.surge.sh |
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
This will need a codemod, right? To deal with the helper text change?
|
@nicolethoen good point. I updated codemod patternfly/pf-codemods#551 to mention providing a warning that consumers should use the new FileUploadHelperText sub-component (right now we only have examples that show using a FormHelperText as a separate piece). |
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
6 participants
What: Closes #9996
codemod: patternfly/pf-codemods#551
Additional issues: