Button update followups

[mcoker]

Following the changes in #10663, I'm finding some more buttons that need to be updated. This isn't an exhaustive list, just what I've come across working on other issues, and 2 of them I've fixed in another PR. We should probably review all of the buttons and make sure they're implemented correctly?

• patternfly-react/packages/react-core/src/components/DatePicker/DatePicker.tsx

  Lines 328 to 338 in 625adc6

  	<button
  	ref={buttonRef}
  	// TODO: Removed style follow up work with issue #8457
  	className={css(buttonStyles.button, buttonStyles.modifiers.control)}
  	aria-label={buttonAriaLabel}
  	type="button"
  	onClick={() => setPopoverOpen(!popoverOpen)}
  	disabled={isDisabled}
  	>
  	<OutlinedCalendarAltIcon />
  	</button>

  • Can we update to use <Button> and pass the icon via the icon prop? If not, we'll need to add the button icon wrapper around that icon.

• patternfly-react/packages/react-core/src/components/Tabs/Tabs.tsx

  Lines 517 to 533 in 625adc6

  	<Button
  	onClick={(event) => toggleTabs(event, !isExpandedLocal)}
  	variant="plain"
  	aria-label={toggleAriaLabel}
  	aria-expanded={isExpandedLocal}
  	id={`${randomId}-button`}
  	aria-labelledby={`${randomId}-text ${randomId}-button`}
  	>
  	<span className={css(styles.tabsToggleIcon)}>
  	<AngleRightIcon arian-hidden="true" />
  	</span>
  	{toggleText && (
  	<span className={css(styles.tabsToggleText)} id={`${randomId}-text`}>
  	{toggleText}
  	</span>
  	)}
  	</Button>

  • Icon needs to be moved into the icon prop. I've updated this in feat(page): support for context selector in sidebar #10686

• patternfly-react/packages/react-core/src/components/JumpLinks/JumpLinks.tsx

  Lines 247 to 257 in 625adc6

  	<Button
  	variant="plain"
  	onClick={() => setIsExpanded(!isExpanded)}
  	aria-label={toggleAriaLabel}
  	aria-expanded={isExpanded}
  	>
  	<span className={styles.jumpLinksToggleIcon}>
  	<AngleRightIcon />
  	</span>
  	{label && <span className={css(styles.jumpLinksToggleText)}> {label} </span>}
  	</Button>

  • Samesies as the tabs above, also updated in feat(page): support for context selector in sidebar #10686