Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/documentation-framework/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { createRoot, hydrateRoot } from 'react-dom/client';
import { Router, useLocation } from '@reach/router';
import 'client-styles'; // Webpack replaces this import: patternfly-docs.css.js
import { SideNavLayout } from '@patternfly/documentation-framework/layouts';
import { Footer } from '@patternfly/documentation-framework/components';
import { MDXTemplate } from '@patternfly/documentation-framework/templates/mdx';
import { routes, groupedRoutes, fullscreenRoutes, getAsyncComponent } from './routes';
import { trackEvent } from './helpers';
Expand Down Expand Up @@ -37,7 +36,6 @@ const AppRoute = ({ child, title, path }) => {
return (
<React.Fragment>
{child}
{process.env.hasFooter && <Footer />}
</React.Fragment>
);
}
Expand All @@ -46,7 +44,7 @@ const SideNavRouter = () => {
const componentsData = process?.env?.componentsData;
return (
<SideNavLayout groupedRoutes={groupedRoutes} navOpen={true} >
<Router id="ws-page-content-router">
<Router id="ws-page-content-router" component="main">
{Object.entries(routes)
.map(([path, { Component, title, sources, id }]) => Component
? <AppRoute
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import SunIcon from '@patternfly/react-icons/dist/esm/icons/sun-icon';
import { SideNav, TopNav, GdprBanner } from '../../components';
import staticVersions from '../../versions.json';
import v5Logo from '../PF-HorizontalLogo-Reverse.svg';
import { Footer } from '@patternfly/documentation-framework/components';

export const RtlContext = createContext(false);

Expand Down Expand Up @@ -301,13 +302,15 @@ export const SideNavLayout = ({ children, groupedRoutes, navOpen: navOpenProp })
<Page
id="ws-page"
mainContainerId="ws-page-main"
mainComponent="div"
header={Header}
sidebar={SideBar}
skipToContent={<SkipToContent href="#ws-page-main">Skip to content</SkipToContent>}
isManagedSidebar
defaultManagedSidebarIsOpen={navOpenProp}
>
{children}
{process.env.hasFooter && <Footer />}
</Page>
<div id="ws-page-banners">
{hasGdprBanner && <GdprBanner />}
Expand Down
1 change: 1 addition & 0 deletions packages/documentation-framework/templates/mdx.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#ws-page-content-router {
display: flex;
flex-direction: column;
flex-grow: 1;
flex-shrink: 0;
}

Expand Down