-
Notifications
You must be signed in to change notification settings - Fork 34
chore(docs): Update README and package file to include info on React 17 #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6e7cbd4 to
4c20a86
Compare
|
Preview: https://chatbot-pr-chatbot-654.surge.sh A11y report: https://chatbot-pr-chatbot-654-a11y.surge.sh |
README.md
Outdated
| import '@patternfly/chatbot/dist/css/main.css'; | ||
| ``` | ||
|
|
||
| If you are using React 17, ChatBot currently has a dependency on [react-markdown](https://github.com/remarkjs/react-markdown) that relies on React 18 and 19. There is an older version of react-markdown that supports 17, but it does not have support for 19. You should be able to add `"react"` and `"react-dom"` of the appropriate version to the `overrides` section of your `package.json` file if you need to use ChatBot with 17. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would they also need to use an override for the react 17 compatible version of react-markdown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Andy didn't mention it, and he's out on PTO. I can call out the specific version in case you think that's valuable.
4c20a86 to
ecd2181
Compare
|
Able to get past install issue with this change - also fixed an instance of useId that won't work with sub-18 versions. Will need to test further to make sure ChatBot isn't 100% broken on 17, but it'll be easier to do that once I have a pre-release I can pull from. |
|
🎉 This PR is included in version 6.4.0-prerelease.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.