Skip to content

WIP: Coalesce and speed up dot products in solvers #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lroberts36 wants to merge 1 commit into
base: lroberts36/solver-timing-2
Choose a base branch
from
Open

WIP: Coalesce and speed up dot products in solvers #1345

lroberts36 wants to merge 1 commit into from

Conversation

@lroberts36
Copy link
Collaborator

@lroberts36 lroberts36 commented Dec 4, 2025

PR Summary

Move variable size check outside of loop and allow for combined reductions as used in BiCGSTAB.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@lroberts36 lroberts36 changed the base branch from develop to lroberts36/solver-timing-2 December 4, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lroberts36