Skip to content

Solver timing #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lroberts36 wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Solver timing #1343

lroberts36 wants to merge 5 commits into from

Conversation

@lroberts36
Copy link
Collaborator

@lroberts36 lroberts36 commented Dec 4, 2025 •
edited
Loading

PR Summary

This PR instruments linear solvers with task based timing.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@lroberts36 lroberts36 changed the base branch from develop to lroberts36/task-list-timing December 4, 2025 21:09
lroberts36
lroberts36 commented Dec 4, 2025
View reviewed changes
example/poisson_gmg/parthenon_app_inputs.cpp
Comment on lines -61 to +64
Real x3 = coords.X<2, te>(k);
Real x3 = coords.X<3, te>(k);
Real x1f = coords.X<1, TE::F1>(k, j, i);
Real x2f = coords.X<2, TE::F2>(k, j, i);
Real x3f = coords.X<2, TE::F3>(k, j, i);
Real x3f = coords.X<3, TE::F3>(k, j, i);
Copy link
Collaborator Author

@lroberts36 lroberts36 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a bug in the code that needed to be fixed somewhere

@lroberts36 lroberts36 changed the title WIP: Solver timing Solver timing Dec 4, 2025
Base automatically changed from lroberts36/task-list-timing to develop December 11, 2025 02:43
@lroberts36 lroberts36 enabled auto-merge December 11, 2025 14:23
pdmullen
pdmullen approved these changes Dec 11, 2025
View reviewed changes
lroberts36
lroberts36 commented Dec 11, 2025
View reviewed changes
lroberts36
lroberts36 commented Dec 11, 2025
View reviewed changes
lroberts36
lroberts36 commented Dec 11, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pdmullen pdmullen pdmullen approved these changes

@Yurlungur Yurlungur Yurlungur approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lroberts36 @Yurlungur @pdmullen