Skip to content

Conversation

@dblythy
Copy link
Member

@dblythy dblythy commented May 23, 2023

Pull Request

Issue

Closes: #8554

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@dblythy dblythy changed the base branch from alpha to release-5.x.x May 23, 2023 05:29
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -9.70 ⚠️

Comparison is base (8e83cac) 94.12% compared to head (0f4e005) 84.42%.

❗ Current head 0f4e005 differs from pull request most recent head 9f83dd0. Consider uploading reports for the commit 9f83dd0 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##           release-5.x.x    #8570      +/-   ##
=================================================
- Coverage          94.12%   84.42%   -9.70%     
=================================================
  Files                183      183              
  Lines              13798    13808      +10     
=================================================
- Hits               12987    11658    -1329     
- Misses               811     2150    +1339     
Impacted Files Coverage Δ
src/ParseServer.js 90.86% <100.00%> (+0.48%) ⬆️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza
Copy link
Member

mtrezza commented May 24, 2023

I don't think we can even merge this into Parse Server 5. The SDK makes a major version jump, so this would be a breaking change.

@dblythy
Copy link
Member Author

dblythy commented May 25, 2023

I attempted to write the subscription code in so that it would be backwards compatible, but I think the minimum node change means that this PR can't be merged

@mtrezza
Copy link
Member

mtrezza commented May 25, 2023

Yes, too bad, but this can always happen, unless we also maintain a LTS version for Parse JS SDK. Once we have a mono-repo that contain both server and sdk it may be easier to do that.

@mtrezza mtrezza closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants