added PromiseWithoutRejectedCallbackFail #479
Conversation
I added a function that demonstrates issue parse-community#456. I'm finding that if I don't specify a rejected callback for the Parse.Config.get() promise's Then method, it never reaches my When method and the function times out. I found this worked in hosted parse but not in the open source version. parse-community#456
| result.config = {}; | ||
|
|
||
| promises.push(Parse.Config.get().then(function(config) { | ||
| result.config = config.attributes; |
There was a problem hiding this comment.
if you add return Parse.Promise.as() there, does it changes any thing?
Can you add a Unit test as well so the failure is properly handled and we ensure no regression in the future?
|
This test doesn't seem to fail in travis, it was a different test that failed. Close/open to trigger tests. |
|
@derekvanvliet updated the pull request. |
|
@drew-gross in that PR the function is actually never run... |
|
Oops yeah missed that. @derekvanvliet can you add a test case that runs this cloud code? |
|
@derekvanvliet updated the pull request. |
|
Looks like there are merge conflicts, I guess you will have to resolve those before travis can run the tests. |
# Conflicts: # spec/ParseAPI.spec.js
|
@derekvanvliet updated the pull request. |
|
Thanks! This will be very helpful as we attempt to fix the issue. |
|
looks like the issue is more around Parse.Config.get() than the promises themselves. |
|
Yeah that is true. @derekvanvliet Parse Config in Parse Server is currently in experimental stage, you can enable it with PARSE_EXPERIMENTAL_CONFIG_ENABLED=1 environment variable. |
4 participants
I added a function that demonstrates issue #456. I'm finding that if I don't specify a rejected callback for the Parse.Config.get() promise's Then method, it never reaches my When method and the function times out. I found this worked in hosted parse but not in the open source version.