feat: allow includeAll with additional includes #367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
includeAllonly provides one level deep, it's currently not possible in the Swift SDK to specifyincludeAllalong with additionalincludekeys, preventing the ability to request the server toincludeAllone level deep and individually specify multiple level deep includesinclude, it's currently possible to send duplicate keys to the server because theincludeargument is an array. Though the server has a dedupe process to handle this, the client will send extra strings when this occursincludeAllproperty addition and method deprecation in feat: add includeAll computed property to Query #362Related issue: #359
Approach
includeAllkey to be sent with additionalincludekeys. Note that as of today, it doesn't look like the server has this feature implemented and will simplyincludeAllinstead of looking at the rest of the keysincludeargument is specified, convert it to aSetto prevent duplicate keys from being sent to the serverTODOs before merging