-
-
Notifications
You must be signed in to change notification settings - Fork 69
fix: add barrier for thread safety #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request!
|
|
@cbaker6 Why are the checks failing? |
Not sure, maybe you can set break points on the failing tests and your changes to determine where the failures are coming from? |
Codecov Report
@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 89.17% 89.09% -0.08%
==========================================
Files 156 156
Lines 14553 14605 +52
==========================================
+ Hits 12977 13013 +36
- Misses 1576 1592 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@vdkdamian can you try the latest branch in your code to see if you still run into the crash in your app? |
|
|
Closing in favor of #394 |


New Pull Request Checklist
Issue Description
This fixes an issue when downloading or uploading multiple items in ParseSwift that was caused by a thread-safety issue.
Related issue: #347
Approach
This PR adds a barrier to fix the related issue
TODOs before merging