Skip to content

Conversation

@vdkdamian
Copy link
Contributor

@vdkdamian vdkdamian commented Mar 2, 2022

New Pull Request Checklist

Issue Description

This fixes an issue when downloading or uploading multiple items in ParseSwift that was caused by a thread-safety issue.

Related issue: #347

Approach

This PR adds a barrier to fix the related issue

TODOs before merging

  • Add entry to changelog
  • Lint

@parse-github-assistant
Copy link

parse-github-assistant bot commented Mar 2, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@vdkdamian
Copy link
Contributor Author

@cbaker6 Why are the checks failing?

@cbaker6
Copy link
Contributor

cbaker6 commented Mar 3, 2022

@cbaker6 Why are the checks failing?

Not sure, maybe you can set break points on the failing tests and your changes to determine where the failures are coming from?

@vdkdamian
Copy link
Contributor Author

vdkdamian commented Mar 3, 2022

Not sure, maybe you can set break points on the failing tests and your changes to determine where the failures are coming from?

I tested it in my app and it works perfectly, but the tests are failing.

It's coming from the test [ParseSwiftTests.ParseFileAsyncTests testFetchFileProgress].
Schermafbeelding 2022-03-03 om 19 32 34

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #348 (a888b84) into main (675168e) will decrease coverage by 0.07%.
The diff coverage is 62.10%.

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   89.17%   89.09%   -0.08%     
==========================================
  Files         156      156              
  Lines       14553    14605      +52     
==========================================
+ Hits        12977    13013      +36     
- Misses       1576     1592      +16     
Impacted Files Coverage Δ
...urces/ParseSwift/API/ParseURLSessionDelegate.swift 12.67% <0.00%> (-3.12%) ⬇️
Sources/ParseSwift/LiveQuery/LiveQuerySocket.swift 69.49% <67.56%> (+4.78%) ⬆️
Sources/ParseSwift/API/API+Command.swift 89.36% <100.00%> (+0.15%) ⬆️
Sources/ParseSwift/Extensions/URLSession.swift 78.63% <100.00%> (+1.46%) ⬆️
Sources/ParseSwift/Objects/ParseUser.swift 85.62% <0.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6
Copy link
Contributor

cbaker6 commented Mar 5, 2022

@vdkdamian can you try the latest branch in your code to see if you still run into the crash in your app?

@vdkdamian
Copy link
Contributor Author

@vdkdamian can you try the latest branch in your code to see if you still run into the crash in your app?

Yes, the crash is back.
Schermafbeelding 2022-03-05 om 08 23 07

@cbaker6 cbaker6 marked this pull request as draft March 29, 2022 14:05
@cbaker6
Copy link
Contributor

cbaker6 commented Aug 27, 2022

Closing in favor of #394

@cbaker6 cbaker6 closed this Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants