Merged
Conversation
Closed
drahnr
reviewed
Sep 26, 2022
drahnr
reviewed
Sep 26, 2022
drahnr
reviewed
Sep 26, 2022
drahnr
reviewed
Sep 26, 2022
drahnr
reviewed
Sep 26, 2022
drahnr
reviewed
Sep 26, 2022
drahnr
reviewed
Sep 26, 2022
drahnr
reviewed
Sep 26, 2022
drahnr
reviewed
Sep 26, 2022
drahnr
reviewed
Sep 26, 2022
Contributor
drahnr
left a comment
There was a problem hiding this comment.
Super nice, a few small~ish nits, mostly around unwrap and a few too many integer types, other than that - hell yeah 🔥
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io>
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io>
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io>
wirednkod
reviewed
Sep 30, 2022
Contributor
|
Sorry for the huge amount of |
Co-authored-by: Nikos Kontakis <wirednkod@gmail.com>
Co-authored-by: Nikos Kontakis <wirednkod@gmail.com>
Co-authored-by: Nikos Kontakis <wirednkod@gmail.com>
Co-authored-by: Nikos Kontakis <wirednkod@gmail.com>
Co-authored-by: Nikos Kontakis <wirednkod@gmail.com>
drahnr
reviewed
Sep 30, 2022
drahnr
reviewed
Sep 30, 2022
wirednkod
approved these changes
Oct 4, 2022
Co-authored-by: Nikos Kontakis <wirednkod@gmail.com>
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a pest based grammar parser, integrated through
wasmby the module zombienet-dsl-parser-wrapper. In order to ingrate the new parser I made a couple of changes of the internal interfaces:cli-> now reads the dsl file and run thenunjucksreplacements and parse it to the newTestDefinitioninterface.test-runner:TestDefinitionas parameterstestFnis generated from an internal registry of funcion generations.Also, the
parsercrate includes aclithat take thedslfile as input and parse it to thejsonrepresentation. We can explore use it in the vscode extension to validate thedslsince produce a nice output thanks to pest :)Thanks!