Skip to content

Override keystore path#2119

Open
RafalMirowski1 wants to merge 11 commits into
mainfrom
override-keystore-path
Open

Override keystore path#2119
RafalMirowski1 wants to merge 11 commits into
mainfrom
override-keystore-path

Conversation

@RafalMirowski1

@RafalMirowski1 RafalMirowski1 commented Oct 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

closes #2095

@pepoviola

pepoviola commented Oct 31, 2025

Copy link
Copy Markdown
Collaborator

Hey @RafalMirowski1 what's the status of this one?
Thx!

@RafalMirowski1 RafalMirowski1 marked this pull request as ready for review October 31, 2025 16:31
@RafalMirowski1

RafalMirowski1 commented Oct 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@pepoviola ok so it works in kubernetes provider as well, but in the example config keystore_path = "{{'network'|zombie('base_path')}}/collator01/relay-data/chains/rococo_local_testnet/keystore" has to be changed to keystore_path = "/relay-data/chains/rococo_local_testnet" for same effect, not sure if good ux, because it's not provider-agnostic?

@pepoviola

pepoviola commented Nov 1, 2025

Copy link
Copy Markdown
Collaborator

keystore_path

hm, let's touch base on this on Monday.

Thx!

@pepoviola

pepoviola commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator

base_path

hm, I don't think this can cause issues, but to be fully agnostic we need to add the logic to translate from native to remote paths (k8s/docker). Could be done in a follow-up pr, wdyt?

@RafalMirowski1

RafalMirowski1 commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

base_path

hm, I don't think this can cause issues, but to be fully agnostic we need to add the logic to translate from native to remote paths (k8s/docker). Could be done in a follow-up pr, wdyt?

Yeah, I agree, this seems fine

@pepoviola

pepoviola commented Nov 21, 2025

Copy link
Copy Markdown
Collaborator

@RafalMirowski1 can you add this new option to the mdBook, then is good to merge.
Thx!

pepoviola
pepoviola requested changes Nov 21, 2025
View reviewed changes

@pepoviola pepoviola left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to add this new key to the mdBook with the proper docs.

@RafalMirowski1

RafalMirowski1 commented Nov 21, 2025

Copy link
Copy Markdown
Contributor Author

Needs to add this new key to the mdBook with the proper docs.

added

pepoviola
pepoviola reviewed Jan 8, 2026
View reviewed changes
Comment thread javascript/packages/orchestrator/src/providers/native/nativeClient.ts
keystore: string,
chainSpecId: string,
dbSnapshot?: string,
longRunning?: boolean,

@pepoviola pepoviola Jan 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this used elsewhere?

@pepoviola pepoviola Jan 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will refactor this later.

pepoviola
pepoviola reviewed Jan 8, 2026
View reviewed changes
Comment thread javascript/packages/orchestrator/src/providers/podman/podmanClient.ts
keystore?: string,
chainSpecId?: string,
dbSnapshot?: string,
longRunning?: boolean,

@pepoviola pepoviola Jan 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pepoviola pepoviola pepoviola approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add some way to override collator keystore path

2 participants

@RafalMirowski1 @pepoviola