Remove unneeded Config bounds and BlockNumber associated type#804
Merged
Remove unneeded Config bounds and BlockNumber associated type#804
Conversation
lexnv
approved these changes
Jan 27, 2023
niklasad1
approved these changes
Jan 27, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some tidyup since we had a bunch of bounds on config associated types that aren't actually needed for Subxt.
Also, the
BlockNumbertype is redundant so I removed it (you can still access this viaT::Header::Number).For now I standardised on everything supporting
Debugeven though not necessary, just incase we want to log things. I could be convinced to remove this though if preferred!