feat: add subscribe_all_blocks and rename subscribe_blocks to subscribe_new_blocks#642
feat: add subscribe_all_blocks and rename subscribe_blocks to subscribe_new_blocks#642yjhmelody wants to merge 3 commits intoparitytech:masterfrom
subscribe_all_blocks and rename subscribe_blocks to subscribe_new_blocks#642Conversation
|
I need to look up what the difference is between Looks ok otherwise (though I may cause a merge conflict with an Rpc PR I'll be merging shortly!) I would note though that the RPC interface will eventually be reworked in Substrate, and so I'm growing hesitant to keep adding RPC methods to this underlying Rpc interface that Subxt doesn't actually use itself. Thus, a better approach I reckon would be that you use the underlying Rpc client yourself to make whatever underlying calls you want. Future versions of Subxt will expose an interfacte to the Runtime APIs directly and automatically, and have a much smaller and more static set of RPC calls to expose, which will be a bunch nicer I reckon :) |
|
The substrate's chain_subscribeNewHeads returns the header of the block if the block is considered the new best block. While the chain_subscribeAllHeads returns the header of new blocks, regardless if they are the best blocks or not. We are working towards having a new unified RPC API for the substrate's node, that will simplify all the |
|
Perhaps your But @yjhmelody I'd like to know what you need this for? But yeah; in general I'd rather not add RPC methods at the moment if Subxt doesn't need them because eventually we'll move over to a new RPC interface anyway and then all of these methods are liable to changing. |
|
This will be addressed in #691 so I'll close this now; the result will be that a new |
No description provided.