Fixed import in subxt-signer::eth#1553
Merged
niklasad1 merged 1 commit intoparitytech:masterfrom Apr 24, 2024
muraca:fix-import-eth-signer
Merged
Fixed import in subxt-signer::eth#1553niklasad1 merged 1 commit intoparitytech:masterfrom muraca:fix-import-eth-signer
subxt-signer::eth#1553niklasad1 merged 1 commit intoparitytech:masterfrom
muraca:fix-import-eth-signer
Conversation
Contributor
|
hmm, most likely a merge conflict or something caused this. Ideally we should check this in the CI but thank you 🌈 |
niklasad1
approved these changes
Apr 22, 2024
Contributor
Author
I saw that the CI only does cargo check with the proper feature, it's weird that this problem is being shown when building only. |
Contributor
|
It's re-producible with It's probably that some features is leaked in our workspace that caused that to work in the CI or that the feature is not checked at all. Anyway thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1552