Rename traits to remove T suffix

[jsdw]

In the end I went for a pattern like:

mod            trait    concrete type              static type        dynamic type
--------------------------------------------------------------------------------------
constants      Address  DefaultAddress<ReturnTy>   StaticAddress<..>  DynamicAddress   
custom_values  Address  -                          StaticAddress<..>  str
storage        Address  DefaultAddress<K,R,F,D,I>  StaticAddress<..>  DynamicAddress<K>
runtime_api    Payload  DefaultPayload<Args,Ret>   StaticPayload<..>  DynamicPayload     
tx             Payload  DefaultPayload<CallData>   StaticPayload<..>  DynamicPayload

Where the static and dynamic types are mostly just aliases to the DefaultX concrete type.

[lexnv]

I think this is fine, just thinking out loud, how would the following look?

• import crate::tx::Signer (not as Signer T)
• Use <Call, Sign> where Sing: Signer<T>?

But yea, we don't have to do it since we already have an OfflineClientT and OnlineClientT to distinguish between concret impl and traits

[jsdw]

Ohyeah, we do use the T pattern for OfflineClient and OnlineClient too don't we; I guess we are still not super consistent hehe. At least those traits are generally not supposed to be imported/used I guess!

Use <Call, Sign> where Sing: Signer?

I think that makes sense!

[lexnv]

LGTM! Nice one! 👍