no_std compatibility for subxt-signer#1477
Merged
tadeohepperle merged 6 commits intomasterfrom Mar 14, 2024
Merged
Conversation
jsdw
reviewed
Mar 13, 2024
jsdw
reviewed
Mar 13, 2024
jsdw
reviewed
Mar 13, 2024
jsdw
reviewed
Mar 13, 2024
jsdw
reviewed
Mar 13, 2024
jsdw
reviewed
Mar 13, 2024
jsdw
reviewed
Mar 13, 2024
Collaborator
jsdw
left a comment
jsdw
left a comment
There was a problem hiding this comment.
Looks good; just some minor comments :)
niklasad1
reviewed
Mar 14, 2024
|
|
||
| /// This is returned if `FromStr` cannot parse a string into a `SecretUri`. | ||
| #[derive(Debug, Copy, Clone, PartialEq, thiserror::Error)] | ||
| #[derive(Debug, Copy, Clone, PartialEq, Display)] |
Contributor
There was a problem hiding this comment.
impl std::error::Error for this one? I saw that James commented on it but I can't find the impl :)
niklasad1
reviewed
Mar 14, 2024
testing/no-std-tests/Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| subxt-metadata = { path = "../../metadata", default-features = false } | ||
| subxt-signer = { path = "../../signer", default-features = false, features = ["sr25519"] } # Note: feature "ecdsa" does not compile to `no-std` right now |
Contributor
There was a problem hiding this comment.
It's probably a good idea to document it somewhere or raise an issue for it
niklasad1
reviewed
Mar 14, 2024
| let _signature = keypair.sign(message); | ||
| let _public_key = keypair.public_key(); | ||
|
|
||
| // Note: `ecdsa` is not compiling for the `thumbv7em-none-eabi` target. |
Contributor
There was a problem hiding this comment.
same here would be nice to have an issue for the ecdsa no-std stuff
niklasad1
approved these changes
Mar 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes subxt-signer no-std compatible. This was factored out into a seperate PR because the
subxt-corePR got a bit big. For this reason, this PR might already make more changes than necessary to the dependency structure, but it is all to make the integration with the mainsubxt-corePR a smooth experience.