rpc v2: chainhead support multiple finalized block hashes in FollowEvent::Initialized#1476
Merged
rpc v2: chainhead support multiple finalized block hashes in FollowEvent::Initialized#1476
FollowEvent::Initialized#1476Conversation
niklasad1
force-pushed
the
na-fix-substrate-tests
branch
from
47ac2d0 to
b5b6667
Compare
niklasad1
force-pushed
the
na-fix-substrate-tests
branch
from
b5b6667 to
7c26b02
Compare
niklasad1
changed the title
block_hash -> finalized_block_hashesblock_hash -> finalized_block_hashes
niklasad1
commented
Mar 11, 2024
niklasad1
changed the title
block_hash -> finalized_block_hashesFollowEvent::Initialized
jsdw
reviewed
Mar 11, 2024
jsdw
reviewed
Mar 11, 2024
jsdw
reviewed
Mar 11, 2024
testing/integration-tests/src/full_client/client/unstable_rpcs.rs
Outdated
Show resolved
Hide resolved
jsdw
reviewed
Mar 11, 2024
jsdw
approved these changes
Mar 11, 2024
Collaborator
jsdw
left a comment
jsdw
left a comment
There was a problem hiding this comment.
LGTM, Just a couple of things!
niklasad1
force-pushed
the
na-fix-substrate-tests
branch
from
284913e to
fc5b897
Compare
lexnv
reviewed
Mar 12, 2024
| this.pin_unpinnable_block_at(rel_block_num, *finalized_block); | ||
|
|
||
| finalized_block_hashes.push(block_ref); | ||
| rel_block_num += 1; |
Collaborator
There was a problem hiding this comment.
nit: would this.rel_block += 1 work here?
Collaborator
There was a problem hiding this comment.
Good spot; now there are multiple we should increment this.rel_block_num here!
Contributor
Author
There was a problem hiding this comment.
the old code didn't increment that but sure lemme fix that..
For example if finalized_block_hashes == vec![one_hash] then it would increment this.rel_block_num which it didn't do before. Cool?
lexnv
approved these changes
Mar 12, 2024
Collaborator
lexnv
left a comment
lexnv
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing this 🙏
This was referenced Mar 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion for paritytech/polkadot-sdk#3445 where it's now possible that the initialized event
can contain multiple finalized block hashes.