Allow either backend to be used in light client code#1455
Closed
Allow either backend to be used in light client code#1455
Conversation
Collaborator
Author
|
Closed in favoru of #1475 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't really like that this needs a new trait etc, and so I think this hints that there's a cleaner way to go about this whole thing.
The light client interface is really just an RpcClient at the end of the day, so maybe it was wrong to go about having a
LightClientstruct, which is essentially just a wrapper aroundOnlineClientanyway (this was my idea, so my bad :)).Maybe the light client APIs should be just focused around creating an RpcClient to talk to whatever chain, and then we add some of the light client functions as high level helpers to
OnlineClient(and then people can alternately create a custom backend with custom RPC client etc to make one instead).