Skip to content

Update Artifacts (auto-generated)#1430

Closed
paritytech-subxt-pr-maker[bot] wants to merge 2 commits intomasterfrom
update-artifacts-1707914723
Closed

Update Artifacts (auto-generated)#1430
paritytech-subxt-pr-maker[bot] wants to merge 2 commits intomasterfrom
update-artifacts-1707914723

Conversation

@paritytech-subxt-pr-maker
Copy link
Copy Markdown
Contributor

This PR updates the artifacts by fetching fresh metadata from a substrate node.
It also recreates the polkadot.rs file used in the integration tests.
It was created automatically by a Weekly GitHub Action Cronjob.

@paritytech-subxt-pr-maker paritytech-subxt-pr-maker bot requested a review from a team as a code owner February 14, 2024 12:45
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tadeohepperle why are the binaries committed here?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that'll be because the CI job explicitly deletes substrate-node but now the polkadot binaries are also downloaded and it doesn't delete those.

I wonder whether there's a more general way to delete any extraneous files like this just to give us more confidence that it won't include anything new in the future

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a PR to address it, sorry I should have thought about this before. I tried to come up with something more generic, could not find a good way to "sandbox" e.g. the use-nodes action and delete all files at once.

@jsdw
Copy link
Copy Markdown
Collaborator

jsdw commented Feb 14, 2024

I guess let's close this and we can re-run or wait for the job to re-run to see if the new PR is good!

@jsdw jsdw closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants