This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Emit error when Config part is imported but without the std feature#9225
Merged
13 commits merged intomasterfrom Jul 16, 2021
Merged
Emit error when Config part is imported but without the std feature#922513 commits merged intomasterfrom
13 commits merged intomasterfrom
Conversation
KiChjang
added
A0-please_review
Contributor
Author
|
I've no idea how to test for this, since it requires import from a test fixtures crate. |
Contributor
|
for test we can have 1 test pallet in frame/support/test/pallet and we import it without std in frame/support/test. Then we can have a UI test for the failing case. |
gui1117
reviewed
Jun 30, 2021
gui1117
reviewed
Jun 30, 2021
Contributor
gui1117
left a comment
gui1117
left a comment
There was a problem hiding this comment.
I think we can improve error message, but otherwise it is good to me
frame/support/test/tests/construct_runtime_ui/no_std_genesis_config.stderr
Outdated
Show resolved
Hide resolved
KiChjang
added
B3-apinoteworthy
and removed
B0-silent
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
gui1117
reviewed
Jul 14, 2021
gui1117
approved these changes
Jul 14, 2021
gui1117
reviewed
Jul 14, 2021
gui1117
reviewed
Jul 14, 2021
shawntabrizi
approved these changes
Jul 16, 2021
Contributor
|
bot merge |
|
Trying merge. |
ghost
merged commit 
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR emits a compiler error when
construct_runtimedetects that theConfigpart is imported, but the corresponding pallet crate does not have thestdfeature enabled, which would cause thePalletConfigstruct to be undefined.