This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Show network id/version in subkey#5457
Merged
bkchr merged 2 commits intoparitytech:masterfrom Mar 30, 2020
Merged
Conversation
- show network id/version when creating - show network id/version when inspecting
|
It looks like @yanganto signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
bkchr
suggested changes
Mar 30, 2020
use `unwrap_or_default` for more clean syntax Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
bkchr
approved these changes
Mar 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Showing the Network ID/Version when creating or inspecting with subkey
This helps a user to confirm the input parameters are correct when creating or inspecting a key with a specific network.