This repository was archived by the owner on Nov 15, 2023. It is now read-only.
skip passed slots and wake up service correctly#4212
Merged
Conversation
gavofyork
reviewed
Nov 26, 2019
| let slot_now = SignedDuration::default().slot_now(slot_duration); | ||
| if slot_now > slot_number { | ||
| // if this is behind, return. | ||
| debug!(target: self.logging_target(), |
Member
There was a problem hiding this comment.
Suggested change
| debug!(target: self.logging_target(), | |
| debug!(target: self.logging_target(), |
gavofyork
approved these changes
Nov 26, 2019
gavofyork
added
A8-looksgood
and removed
A0-please_review
andresilva
approved these changes
Nov 26, 2019
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a fast-path for avoiding proposing for slots that have already passed. The service future was also not being woken up correctly when essential tasks exited.