frame: GenesisBuild::build allowed in no_std by michalkucharczyk · Pull Request #14107 · paritytech/substrate

michalkucharczyk · 2023-05-09T15:29:23Z

GenesisBuild::build function will be required for no_std in no native runtime world.

GenesisBuild::build macro generated function allows to build the runtime GenesisConfig assembled from all pallets' GenesisConfigs. build for runtime will be implemented in follow-up.

Step towards: paritytech/polkadot-sdk#25

polkadot companion: paritytech/polkadot#7271
cumulus companion: paritytech/cumulus#2624

i`GenesisBuild::build` function will be required for no_std in no native runtime world. `GenesisBuild::build` macro generated function allows to build the runtime GenesisConfig assembled from all pallets' GenesisConfigs.

bkchr

I'm not sure we should already do this? I mean we can probably get rid off this trait entirely when we just write all genesis values to the state and on the node side, after calling the runtime api, taking the OverlayedChanges to fetch all the state changes. Then we basically achieve the same as currently is being achieved by this trait.

ggwpez · 2023-05-09T16:19:10Z

Get rid of the trait?!

I know that we normally use it in tests to write a genesis config to storage.

bkchr · 2023-05-09T16:20:49Z

I know that we normally use it in tests to write a genesis config to storage.

Good point, I forgot about tests! Still doesn't mean we need it in no_std :D

michalkucharczyk · 2023-05-09T16:24:08Z

I'm not sure we should already do this? I mean we can probably get rid off this trait entirely when we just write all genesis values to the state and on the node side, after calling the runtime api, taking the OverlayedChanges to fetch all the state changes. Then we basically achieve the same as currently is being achieved by this trait.

We need a function that calls the build function of all the pallets in runtime, which in turn put the values into storage (see: https://github.com/paritytech/substrate/blob/c014d4a876b1b9db9affabfc19ba1707831c8c3f/frame/system/src/lib.rs#LL647C15-L647C15). And we need it in no_std.

So the idea is to use this generated function from new GenesisBuilder Runtime API.

The storage part can be removed later.

bkchr

Good points @michalkucharczyk!

- #[cfg(feature = "std")] is not longer added to GenesisBuild implementation.

michalkucharczyk · 2023-05-10T10:42:22Z

GenesisConfig::build function expects AccountId to be Display:

substrate/frame/elections-phragmen/src/lib.rs

Lines 748 to 750 in 14855e6

    
           Ok(_) => { 
        
           	panic!("Duplicate member in elections-phragmen genesis: {}", member) 
        
           },

What would be your preference to solve this?

Changing bounds of AccountId to Display seems to heavy for me:

substrate/frame/system/src/lib.rs

Lines 278 to 284 in 14855e6

    
           		type AccountId: Parameter 
        
           			+ Member 
        
           			+ MaybeSerializeDeserialize 
        
           			+ Debug 
        
           			+ MaybeDisplay 
        
           			+ Ord 
        
           			+ MaxEncodedLen;

KiChjang · 2023-05-10T12:47:29Z

Huh, so MaybeDisplay is not working because we now are making sure that GenesisBuild is always Display regardless of whether the std feature is enabled or not. I think it is fine to replace MaybeDisplay with Display, since most AccountId types would most certainly have a Display impl (otherwise I don't know how they attempt to show an account ID via the logs).

michalkucharczyk · 2023-05-10T13:17:16Z

Huh, so MaybeDisplay is not working because we now are making sure that GenesisBuild is always Display

Actually it is not about the GenesisBuild trait. It is only one, stand-alone case where panic! is used in GenesisBuild::build function.

Adding Display bound is ok, but it will pull all the (maybe unneccesarily) display staff into wasm runtime.

bkchr · 2023-05-10T13:33:57Z

GenesisConfig::build function expects AccountId to be Display:

substrate/frame/elections-phragmen/src/lib.rs

Lines 748 to 750 in 14855e6

Ok(_) => {

panic!("Duplicate member in elections-phragmen genesis: {}", member)

},

What would be your preference to solve this?

Changing bounds of AccountId to Display seems to heavy for me:

substrate/frame/system/src/lib.rs

Lines 278 to 284 in 14855e6

type AccountId: Parameter

+ Member

+ MaybeSerializeDeserialize

+ Debug

+ MaybeDisplay

+ Ord

+ MaxEncodedLen;

Just use debug printing?

KiChjang · 2023-05-10T13:37:51Z

Ah ok, yes, the panic! macro should really be using debug printing anyway.

Polkadot-Forum · 2023-05-17T14:23:02Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/genesisconfig-in-wasm-runtime-a-step-towards-a-non-native-future/2887/1

KiChjang · 2023-05-18T08:01:53Z

As soon as CI is green, I believe this is ready to merge.

michalkucharczyk · 2023-05-20T07:37:29Z

bot rebase

…esis-for-no-std

paritytech-processbot · 2023-05-20T07:37:36Z

Rebased

…esis-for-no-std

cargo update -p frame-support-test-pallet -p frame-support-test

…esis-for-no-std

michalkucharczyk · 2023-05-23T14:55:55Z

bot rebase

…esis-for-no-std

paritytech-processbot · 2023-05-23T14:56:01Z

Rebased

michalkucharczyk · 2023-05-23T16:19:16Z

I've added requried companions, some pallets in cumulus and polkadot didn't implement Default in no_std.

michalkucharczyk · 2023-05-25T09:25:29Z

bot rebase

…esis-for-no-std

paritytech-processbot · 2023-05-25T09:25:34Z

Rebased

michalkucharczyk · 2023-05-25T21:00:01Z

bot rebase

…esis-for-no-std

paritytech-processbot · 2023-05-25T21:00:07Z

Rebased

michalkucharczyk · 2023-05-25T21:49:15Z

bot merge

* frame: GenesisBuild::build allowed in no_std i`GenesisBuild::build` function will be required for no_std in no native runtime world. `GenesisBuild::build` macro generated function allows to build the runtime GenesisConfig assembled from all pallets' GenesisConfigs. * fixes * GenesisBuild::build avaiable in no-std - #[cfg(feature = "std")] is not longer added to GenesisBuild implementation. * system: hash69 available for no-std * elections-phragmen: panic message fixed for no_std * frame::suport: doc updated * test-runtime: default for GenesisConfig * frame::test-pallet: serde/std added to std feature deps * Cargo.toml: deps sorted * Cargo.lock update cargo update -p frame-support-test-pallet -p frame-support-test * frame ui tests: cleanup --------- Co-authored-by: parity-processbot <>

frame: GenesisBuild::build allowed in no_std

2541dd0

i`GenesisBuild::build` function will be required for no_std in no native runtime world. `GenesisBuild::build` macro generated function allows to build the runtime GenesisConfig assembled from all pallets' GenesisConfigs.

michalkucharczyk requested a review from a team May 9, 2023 15:29

michalkucharczyk added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 9, 2023

paritytech deleted a comment from paritytech-cicd-pr May 9, 2023

paritytech deleted a comment from command-bot bot May 9, 2023

bkchr suggested changes May 9, 2023

View reviewed changes

bkchr approved these changes May 9, 2023

View reviewed changes

fixes

4c9119e

liamaharon approved these changes May 10, 2023

View reviewed changes

michalkucharczyk added 2 commits May 10, 2023 11:43

GenesisBuild::build avaiable in no-std

2528059

- #[cfg(feature = "std")] is not longer added to GenesisBuild implementation.

system: hash69 available for no-std

85e3e39

KiChjang approved these changes May 10, 2023

View reviewed changes

elections-phragmen: panic message fixed for no_std

f6c9fa8

michalkucharczyk requested a review from a team May 10, 2023 13:56

frame::suport: doc updated

4785625

sam0x17 approved these changes May 17, 2023

View reviewed changes

KiChjang approved these changes May 18, 2023

View reviewed changes

Merge remote-tracking branch 'origin/master' into mku-frame-build-gen…

94a809e

…esis-for-no-std

michalkucharczyk added 7 commits May 22, 2023 15:14

test-runtime: default for GenesisConfig

0bbd184

Merge remote-tracking branch 'origin/master' into mku-frame-build-gen…

564d120

…esis-for-no-std

frame::test-pallet: serde/std added to std feature deps

772693e

Cargo.toml: deps sorted

6556f0f

Cargo.lock update

ce44ae6

cargo update -p frame-support-test-pallet -p frame-support-test

frame ui tests: cleanup

b5c5f49

Merge remote-tracking branch 'origin/master' into mku-frame-build-gen…

20e2a31

…esis-for-no-std

michalkucharczyk mentioned this pull request May 23, 2023

pallets: implement Default for GenesisConfig in no_std paritytech/polkadot#7271

Merged

acatangiu approved these changes May 23, 2023

View reviewed changes

michalkucharczyk mentioned this pull request May 23, 2023

pallets: implement Default for GenesisConfig in no_std paritytech/cumulus#2624

Merged

Merge remote-tracking branch 'origin/master' into mku-frame-build-gen…

c08bc5f

…esis-for-no-std

gilescope approved these changes May 23, 2023

View reviewed changes

Merge remote-tracking branch 'origin/master' into mku-frame-build-gen…

4966ca1

…esis-for-no-std

Merge remote-tracking branch 'origin/master' into mku-frame-build-gen…

d52fc41

…esis-for-no-std

paritytech-processbot bot merged commit f4cb21c into master May 25, 2023

paritytech-processbot bot deleted the mku-frame-build-genesis-for-no-std branch May 25, 2023 21:49

nazar-pc mentioned this pull request Jun 16, 2023

Upgrade Substrate (with core-evm-relay removed) autonomys/subspace#1549

Merged

1 task

Conversation

michalkucharczyk commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkchr left a comment

Choose a reason for hiding this comment

Uh oh!

ggwpez commented May 9, 2023

Uh oh!

bkchr commented May 9, 2023

Uh oh!

michalkucharczyk commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkchr left a comment

Choose a reason for hiding this comment

Uh oh!

michalkucharczyk commented May 10, 2023

Uh oh!

KiChjang commented May 10, 2023

Uh oh!

michalkucharczyk commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkchr commented May 10, 2023

Uh oh!

KiChjang commented May 10, 2023

Uh oh!

Polkadot-Forum commented May 17, 2023

Uh oh!

KiChjang commented May 18, 2023

Uh oh!

michalkucharczyk commented May 20, 2023

Uh oh!

paritytech-processbot bot commented May 20, 2023

Uh oh!

michalkucharczyk commented May 23, 2023

Uh oh!

paritytech-processbot bot commented May 23, 2023

Uh oh!

michalkucharczyk commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michalkucharczyk commented May 25, 2023

Uh oh!

paritytech-processbot bot commented May 25, 2023

Uh oh!

michalkucharczyk commented May 25, 2023

Uh oh!

paritytech-processbot bot commented May 25, 2023

Uh oh!

michalkucharczyk commented May 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

michalkucharczyk commented May 9, 2023 •

edited

Loading

michalkucharczyk commented May 9, 2023 •

edited

Loading

michalkucharczyk commented May 10, 2023 •

edited

Loading

michalkucharczyk commented May 23, 2023 •

edited

Loading