Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Improve has good jugement#13952

Merged
paritytech-processbot[bot] merged 6 commits intoparitytech:masterfrom
itmilos:improve_has_good_jugement
Apr 19, 2023
Merged

Improve has good jugement#13952
paritytech-processbot[bot] merged 6 commits intoparitytech:masterfrom
itmilos:improve_has_good_jugement

Conversation

@itmilos
Copy link
Copy Markdown
Contributor

@itmilos itmilos commented Apr 19, 2023

Used map and map_or method instead of an if let statement.

@ggwpez ggwpez added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 19, 2023
@bkchr
Copy link
Copy Markdown
Member

bkchr commented Apr 19, 2023

bot merge

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Apr 19, 2023

Waiting for commit status.

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Apr 19, 2023

Merge cancelled due to error. Error: Statuses failed for 2f04bed

ggwpez
ggwpez reviewed Apr 19, 2023
View reviewed changes
@ggwpez
Copy link
Copy Markdown
Member

ggwpez commented Apr 19, 2023

bot merge

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Apr 19, 2023

Waiting for commit status.

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Apr 19, 2023

Merge cancelled due to error. Error: Statuses failed for 17be838

@ggwpez
Copy link
Copy Markdown
Member

ggwpez commented Apr 19, 2023

bot fmt

@command-bot
Copy link
Copy Markdown

command-bot bot commented Apr 19, 2023 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2700643 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 37-2e8d2cd2-9c21-462c-bf0f-83b0c660191c to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link
Copy Markdown

command-bot bot commented Apr 19, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2700643 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2700643/artifacts/download.

@ggwpez
Copy link
Copy Markdown
Member

ggwpez commented Apr 19, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit d4802eb into paritytech:master Apr 19, 2023
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@itmilos @ggwpez @nathanwhit
Improve has good jugement (paritytech#13952)
5ff3de0 
* improve run_benchmark

* Revert "improve run_benchmark"

This reverts commit 4d9cf7a.

* improve has_good_judgement

* Update bin/node/runtime/src/impls.rs

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itmilos @bkchr @ggwpez