This repository was archived by the owner on Nov 15, 2023. It is now read-only.
imp function comparison#13928
Merged
paritytech-processbot[bot] merged 1 commit intoparitytech:masterfrom Apr 17, 2023
Merged
Conversation
bkchr
approved these changes
Apr 16, 2023
bkchr
added
A2-insubstantial
ggwpez
approved these changes
Apr 17, 2023
Member
|
bot merge |
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**Description:
In the refactored code, I replaced the series of if statements with a single match expression, which is more concise and easier to read.
Labels: You labeled the PR appropriately if you have permissions to do so:
A*for PR status (one required)