This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Open
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A0-please_review
Member
Author
|
bot bench $ pallet dev pallet_message_queue |
ggwpez
changed the title
discard_overweight call
sam0x17
approved these changes
May 1, 2023
Contributor
sam0x17
left a comment
sam0x17
left a comment
There was a problem hiding this comment.
looks good to me, just a few nits and questions
12 tasks
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
sam0x17
approved these changes
May 18, 2023
muharem
reviewed
May 22, 2023
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
muharem
approved these changes
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
discard_overweightcall to the MQ pallet for polkadot#6271 to discard overweight (but not yet stale) messages. Thereap_pagefunctionality to remove stale pages is not sufficient in the case that the number of max-stale pages is not reachable by the maximal number of configured messages. This allows to still remove overweight messages and not clog up the queue.discard_overweightto theServiceQueuestrait.AsEnsureOriginWithContainsPair: AnEnsureOriginthat is filtered through aContainsPairpredicate.EitherOfWithArg: A homogenous typedEitherOfthat additionally takes an argument.Context
The
DiscardOverweightOriginwill be configured in Polkadot to allow each parachain's sovereign account to discard overweight messages from their UMP queue.