This repository was archived by the owner on Nov 15, 2023. It is now read-only.
WASM executor: add OutputExceedsBounds variant to Error#13841
Merged
paritytech-processbot[bot] merged 2 commits intomasterfrom Apr 7, 2023
Merged
Conversation
Previously this was a `WasmError`, which is intended for runtime construction errors. However this led to confusion as output-exceeds-bounds occurs due to execution of `validate_block`.
mrcnski
added
A0-please_review
6 tasks
bkchr
approved these changes
Apr 6, 2023
koute
approved these changes
Apr 7, 2023
Contributor
koute
left a comment
koute
left a comment
There was a problem hiding this comment.
In general it'd be nice to just completely get rid of the Other variant if possible.
Author
Agreed and I thought about it, but didn't feel like doing it. 😛 Raised #13853. |
Author
|
bot merge |
paritytech-processbot
bot
deleted the
mrcnski/wasm-executor-outputexceedsbounds-error
branch
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…ch#13841) * WASM executor: add `OutputExceedsBounds` variant to `Error` Previously this was a `WasmError`, which is intended for runtime construction errors. However this led to confusion as output-exceeds-bounds occurs due to execution of `validate_block`. * Fix warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
Previously this was a
WasmError, which is intended for runtime construction errors. However this led to confusion as output-exceeds-bounds occurs due to execution ofvalidate_block.(Please review closely and correct me if I'm mistaken about something, the error story here is pretty confusing.)